xia.silei/DanDingNoneBot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
102 Commits 2 Branches 0 Tags
main
Commit Graph

102 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mr.Xia
cbc0f5198a fix(onmyoji_gacha): 避免重复签到发放积分 2026-06-20 19:00:41 +08:00
Mr.Xia
8d26c46323 feat(bot): use runtime api for bot data 2026-06-20 18:20:40 +08:00
Mr.Xia
f67f3ca1d6 fix(danding_api): 从NoneBot2 driver.config读取token 
.env 被 NoneBot2 读入 driver.config（小写键名）而非 os.environ，
改用 getattr(driver.config, "danding_api_token") 获取。

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-28 12:24:24 +08:00
Mr.Xia
29ae3695af debug(danding_api): 列出所有相关环境变量排查token加载 
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-28 12:15:33 +08:00
Mr.Xia
df0f2ebfbe fix(danding_api): 手动读取环境变量兜底token配置 
get_plugin_config(BaseSettings) 不一定从 .env 读取环境变量，
直接用 os.environ.get 兜底确保 DANDING_API_TOKEN 能被加载。

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-28 12:11:02 +08:00
Mr.Xia
d77007f5a2 debug(danding_api): 添加post_vcode请求参数调试日志 
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-28 11:41:04 +08:00
Mr.Xia
e68305d306 fix(danding_api): 将Config改为BaseSettings以支持环境变量读取 
BaseModel 的 Field(env=...) 不会自动读取环境变量，
需要继承 pydantic_settings.BaseSettings 才能生效。

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-28 11:27:49 +08:00
Mr.Xia
d1f97eccc2 fix(danding_api): 修复配置未从环境变量读取导致API鉴权失败 
Token 和 EMAIL_PASSWORD 字段缺少 Field(env=...) 声明，
导致 .env 中的 DANDING_API_TOKEN 始终无法被读取，
后端 API 返回"你没有权限这样做"。

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-28 11:17:26 +08:00
Mr.Xia
c2ba9d2f74 fix(qqpush): 修复token配置读取导致的404 2026-05-27 17:25:31 +08:00
Mr.Xia
1b484d7fda fix: 修复 damo_balance 引号语法错误及 chatai bleach 缺失依赖 
- damo_balance/__init__.py: 将外层字符串改为单引号，消除内嵌双引号引起的 SyntaxError
- chatai/screenshot.py: bleach 改为 try/except 可选导入，无 bleach 时降级跳过 HTML 净化
- requirements.txt: 补充 openai>=1.0.0 与 pyppeteer>=1.0.2 依赖声明
 2026-05-11 22:43:27 +08:00
Mr.Xia
3db17fc08b merge: resolve onmyoji_gacha conflicts 2026-05-11 22:32:13 +08:00
Mr.Xia
7556352477 docs: add remaining review reports and docs 2026-05-10 00:43:18 +08:00
Mr.Xia
e85eefa1c3 docs: add FINAL_REVIEW_REPORT.md (project-level review) 2026-05-10 00:42:49 +08:00
Mr.Xia
44052bc6e8 docs: add REVIEW_REPORT.md for all 11 plugins (round 2 review) 2026-05-10 00:39:37 +08:00
Mr.Xia
260c66636e review(onmyoji_gacha): fix 2x timeout + Pydantic v2 model_validator + review report 2026-05-10 00:37:18 +08:00
Mr.Xia
c62ac37611 review: fix critical/medium bugs in 4 plugins (round 2) 
group_horse_racing:
- settle_race: rewrite with 7 bug fixes (race condition, draw double-credit, empty participants, etc.)
- models.py: reorder fields for correct defaults, add indexes
- message_service: add logger import

danding_points:
- api.py: add finally blocks to 3 methods (add_points, get_history, get_leaderboard)
- database.py: add finally block to get_user_balance

chatai:
- __init__.py: deprecated API→asyncio.to_thread, deduplicate logging, taskkill filter for safety
- screenshot.py: XSS protection with bleach on HTML content
- requirements.txt: add bleach dependency

danding_qqpush:
- api.py L13: fix self-referencing _renderer NameError crash
- api.py: lazy singleton pattern via _get_renderer() instead of per-request ImageRenderer
- __init__.py: mask Token in log output (security)

All 34 tests pass.
 2026-05-10 00:30:22 +08:00
Mr.Xia
f61465a95b fix(danding_api): 安全修复+性能改进 
- config.py: 硬编码Token/EMAIL_PASSWORD→环境变量
- utils.py: requests→aiohttp异步IO
- utils.py: 移除硬编码用户ID
- utils.py: 可变默认参数dict()→None
- utils.py: 全局session_id封装为函数
- utils.py: tab→4空格统一缩进
 2026-05-09 23:52:10 +08:00
Mr.Xia
e28d871940 fix(chatai): 安全修复+代码质量改进 
- _force_kill_chrome: 仅kill带--remote-debugging-port的headless chrome
- AI API: 添加60s timeout + run_in_executor避免阻塞事件循环
- AI系统提示抽取为常量
- markdown转图片: 移除错误的html.escape前置
- screenshot: 等待渲染完成替代固定sleep
- 错误信息不再暴露异常详情给用户
 2026-05-09 23:48:54 +08:00
Mr.Xia
f240ba2882 perf+fix(danding_qqpush): perf优化+安全修复+代码DRY 
- image_render: cached draw object, font.getlength() 替代逐字符创建临时Image
- image_render: 移除PNG无效的quality参数
- api.py: ImageRenderer单例复用(避免每请求重载字体)
- api.py: 异常详情不再泄露到API响应
- sender.py: 提取_send_msg()消除重复代码
 2026-05-09 23:46:44 +08:00
Mr.Xia
b444bd62f5 security: move onmyoji_gacha BOT_TOKEN to env var (was hardcoded plaintext) 2026-05-09 23:42:48 +08:00
Mr.Xia
fd2fd90f05 refactor: extract admin check helper & harden room_store JSON parsing 
- Extract duplicated admin/owner check from race.py into shared._is_admin_or_owner()
- Add try/except around JSON.loads in room_store.load_rooms for corrupted data resilience
- Use .get() for safer dict access in room deserialization
 2026-05-09 23:37:55 +08:00
Mr.Xia
14397ab645 fix(danding_points): improve conn management in api.py 
- Read methods (get_balance/get_transactions/get_ranking): add try/except/finally
- Write methods (add/spend/set_points): add rollback() before early return conn.close()
- Prevents connection leaks on exceptions and early returns
 2026-05-09 23:34:07 +08:00
Mr.Xia
e94161e802 test: add unit tests for models, payout logic, and room lock 
- test_models.py: 10 tests for Room/Horse/Bet/RaceResult dataclasses
- test_payout_logic.py: 12 tests for payout formula (max+round)
- test_room_store_lock.py: 5 tests for get_lock() setdefault pattern
- All 34 tests pass in 0.27s
 2026-05-09 23:31:54 +08:00
Mr.Xia
9a4c708079 chore(deps): remove 7 unused packages (tortoise-orm, asyncmy, asyncodbc, asyncpg, pyodbc, pypika-tortoise, nonebot-plugin-tortoise-orm) 
None of these packages are imported by any plugin. Saves ~15 transitive deps.
 2026-05-09 23:28:21 +08:00
Mr.Xia
dd3cfdace6 docs(review): add FINAL_REVIEW_REPORT.md - Phase 3 infrastructure & cross-plugin consistency analysis 2026-05-09 23:25:22 +08:00
Mr.Xia
c01338f496 refactor(plugins): comprehensive code review - ~35 fixes across 14 plugins 
Phase 1 - Plugin code review (14/14 plugins):
- Security: 3x token leak in print→logger.debug, Bearer prefix handling
- Bug: bare except→specific exceptions, HorseState type safety, sync→async
- Critical: response_model undefined, route dead code, sync blocking event loop
- Quality: 11x print()→logger, variable name shadowing, consistent logging

Phase 2 - Deep analysis:
- Fix: payout int truncation→max(1, round(amount*odds))
- Fix: room_store get_lock race condition→dict.setdefault()
- Verify: data_manager f-string SQL is safe (uses ? placeholders)

Infrastructure: review reports generated for all plugins.
 2026-05-09 23:22:28 +08:00
Mr.Xia
698b0ec93a fix: 添加"三连"别名并将三连抽优先级调整为10 2026-05-03 11:20:45 +08:00
Mr.Xia
0ed20f9a4a fix: rules.py ALLOWED_GROUPS→ALLOWED_GROUP_ID整数比较 2026-05-03 10:37:36 +08:00
Mr.Xia
bf97fe3fd1 fix: restore cross-plugin points_api import in onmyoji_gacha 2026-05-03 10:00:39 +08:00
Mr.Xia
0312c79c9d refactor: onmyoji gacha plugin overhaul (gacha-refactor) 2026-05-03 09:55:34 +08:00
Mr.Xia
9a8cb3ad6d 移除赛马帮助命令的管理员权限鉴权 2026-05-02 16:32:35 +08:00
Mr.Xia
56b56e4e85 fix: room_store __db name mangling + add singleton 2026-05-02 16:07:16 +08:00
Mr.Xia
d3b5499896 fix: add room_store singleton instance 2026-05-02 16:06:04 +08:00
Mr.Xia
69d4a17674 fix: remove nonexistent handle_access import 2026-05-02 16:01:06 +08:00
Mr.Xia
a952760cf8 fix: break circular import in horse racing commands 
Extract shared.py from commands/__init__.py to break circular dependency:
- shared.py: shared variables/services/helper functions
- access.py: get_scope/check_access/get_event_id (canonical source)
- __init__.py: re-exports from shared.py for backward compat
- register/bet/race/help: import from .shared instead of package
 2026-05-02 15:38:34 +08:00
Mr.Xia
5fae4a271a fix: add bot.py entry point and danding_bot/__init__.py 2026-05-02 14:56:12 +08:00
Mr.Xia
fe081f43cf fix(race): 代码质量审查修复 + commands包拆分 + 赛马取消命令 
- P1: bet.py赔率计算移入锁内防竞态
- P1: config.py TESTERS解析失败添加warning日志
- P2: 新增赛马取消命令(积分退还/任务取消/状态重置)
- P3: bet.py清理未使用的_send_to_scope导入
- 将commands.py拆分为commands/包(access/bet/help/race/register)
- OpenSpec变更提案: fix-race-conditions-and-logs
 2026-05-02 14:33:34 +08:00
Mr.Xia
5869618a9c feat(horse-racing): 新增赛马列表/取消下注/开赛权限限制 + 修复退还异常保护 + 文档同步 2026-05-02 11:50:34 +08:00
Mr.Xia
9566920866 chore: 归档fix-horse-racing-issues提案 2026-05-01 23:15:08 +08:00
Mr.Xia
a2b7e1fc11 fix: settle_race返回tuple消除odds重复计算 
- settle_race() 返回 tuple[RaceResult, odds] | None
- run_race_with_settlement 解包使用，移除多余 calculate_odds 调用
- _test_send_to_scope 签名已兼容(含*args/**kwargs)
 2026-05-01 23:04:32 +08:00
Mr.Xia
569801dd14 fix: 赛马插件P0-P2问题修复 
- P0: room_store sqlite3→aiosqlite异步化
- P0: points_service统一异常处理+轻量重试
- P0: _send_to_scope加warning日志
- P1: 积分历史记录补充source/reason字段
- P1: 赛马结算写入赔率快照(odds_snapshot)
- P1: test_commands改为commands_mod间接引用(测试隔离)
- P2: 马名去重统一casefold()比较
 2026-05-01 22:50:14 +08:00
Mr.Xia
dd8781a74d Merge branch 'main' of https://git.370888.xyz/xia.silei/DanDingNoneBot 2026-04-10 21:14:11 +08:00
Mr.Xia
17dd19330e chore: 清理测试脚本并更新插件文档 
- 删除过时的测试脚本，包括测试配置、路由、API、积分、签到等文件
- 更新 PLUGINS.md 文档，重新组织插件结构，提供更清晰的功能说明和权限要求
- 改进文档格式，增加表格和详细说明，便于用户理解各插件功能
 2026-04-10 21:14:05 +08:00
Mr.Xia
f1f7d4cd1e chore: 清理测试脚本并更新插件文档 
- 删除过时的测试脚本，包括测试配置、路由、API、积分、签到等文件
- 更新 PLUGINS.md 文档，重新组织插件结构，提供更清晰的功能说明和权限要求
- 改进文档格式，增加表格和详细说明，便于用户理解各插件功能
 2026-04-10 21:13:46 +08:00
Mr.Xia
b86cc009e9 refactor: 移除插件初始化时的配置打印日志 
这些调试日志在生产环境中会造成不必要的控制台输出，移除后使代码更简洁。
 2026-04-07 20:51:40 +08:00
Mr.Xia
b4f71ddb3b docs(赛马插件): 更新命令说明并改进默认马名逻辑 
- 在README中补充命令参数和示例
- 当未提供马名时，自动使用用户昵称作为默认马名
- 优化帮助文本中的命令描述
 2026-04-07 20:50:28 +08:00
Mr.Xia
9205b1af8b fix(配置): 清空特殊概率用户列表默认值 
将 SPECIAL_PROBABILITY_USERS 默认值从包含特定用户ID的列表改为空列表，避免默认开启特殊概率功能。
 2026-04-07 20:46:46 +08:00
Mr.Xia
f81fffcf50 test: 增加测试超时时间以提升稳定性 
- 将模拟赛事的等待超时从60秒延长至180秒（实时进度）和15秒延长至30秒（非实时）
- 避免测试因网络延迟或处理时间不足而意外失败
 2026-04-07 20:42:32 +08:00
Mr.Xia
5df0487b88 fix(测试): 修复完全模拟比赛测试中的消息验证逻辑 
- 将消息列表中的消息强制转换为字符串，避免类型错误
- 使用 any() 检查关键消息是否存在，而不是依赖固定索引
- 改进开赛名单和进度消息的验证逻辑
- 修复回合进度条目数量检查的逻辑
 2026-04-07 20:38:31 +08:00
Mr.Xia
33b75d46f8 fix(test): 修复模拟消息发送返回类型不匹配的问题 
将返回的消息ID从字符串类型改为包含message_id键的字典，以匹配实际接口的返回格式。
 2026-04-07 20:35:16 +08:00