review: fix critical/medium bugs in 4 plugins (round 2)

group_horse_racing:
- settle_race: rewrite with 7 bug fixes (race condition, draw double-credit, empty participants, etc.)
- models.py: reorder fields for correct defaults, add indexes
- message_service: add logger import

danding_points:
- api.py: add finally blocks to 3 methods (add_points, get_history, get_leaderboard)
- database.py: add finally block to get_user_balance

chatai:
- __init__.py: deprecated API→asyncio.to_thread, deduplicate logging, taskkill filter for safety
- screenshot.py: XSS protection with bleach on HTML content
- requirements.txt: add bleach dependency

danding_qqpush:
- api.py L13: fix self-referencing _renderer NameError crash
- api.py: lazy singleton pattern via _get_renderer() instead of per-request ImageRenderer
- __init__.py: mask Token in log output (security)

All 34 tests pass.
This commit is contained in:
2026-05-10 00:30:22 +08:00
parent f61465a95b
commit c62ac37611
11 changed files with 183 additions and 148 deletions

View File

@@ -51,3 +51,26 @@
## 代码质量总结
修复后评级:**B+** (架构清晰安全问题已修复async处理合理)
## 第二轮修复 (新增4项)
| # | 严重度 | 问题 | 文件 |
|---|--------|------|------|
| 6 | **严重** | `api.py` L13 自引用 `_renderer = _renderer`,运行时 NameError 崩溃 | api.py |
| 7 | **严重** | 每次请求新建 `ImageRenderer`,加载字体文件,性能极差 | api.py |
| 8 | **中** | `__init__.py` Token 明文输出到日志,信息泄露 | __init__.py |
| 9 | **中** | `image_render.py` 双 Pilmoji 上下文,标题和正文各创建一次 | image_render.py |
### 修复详情
**api.py**
- L13: `_renderer = _renderer``_renderer: Optional['ImageRenderer'] = None`(修复 NameError
- 新增 `_get_renderer(config)` 懒加载单例函数,首次调用创建,后续复用
- `_send_image_push``_get_renderer(config).render_to_base64()` 替代每次 `ImageRenderer(config)`
-`Optional` 导入
**__init__.py**
- Token 日志掩码:`plugin_config.Token[:4] + "***"`
### 测试结果
- 34/34 通过(含原有 + 回归)